Remove Cluster & XPack clients from HLRC (#83423) #83593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi @gmarouli, I've created a changelog YAML for you. |
66 tasks
Contributor
Author
|
@elasticmachine run elasticsearch-ci/part-1 |
dakrone
approved these changes
Feb 7, 2022
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
LGTM assuming CI is happy, thanks Mary!
Member
|
Oh hah, I liked this PR so much I reviewed it twice, whoops! |
Contributor
Author
I share the excitement, I got to see a bit more of the clients and the tests, it was a good opportunity! Also, cleaning code like this is sooooo awesome! It might be counter intuitive for the people that see developers as code producing machines but it makes total sense in reality ;). I am working on tests, 2 failures were my fault. I think I fixed it but let's see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.