Remove DiscoveryNodes#getAllNodes #83538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteam
added
>non-issue
:Distributed Indexing/Distributed
Since DiscoverNodes now extends `AbstractCollection` we don't need a method exposing DiscoveryNodes as a `Collection` and we can call `stream` directly on `DiscoveryNodes` See elastic#83453
arteam
force-pushed
the
remove-discovery-nodes-all-nodes
branch
from
fc4a9d4 to
0ae3ba8
Compare
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/part-2 |
idegtiarenko
approved these changes
Feb 7, 2022
Contributor
Author
|
Thanks Ievgen! |
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Feb 7, 2022
Since DiscoverNodes now extends `AbstractCollection` we don't need a method exposing DiscoveryNodes as a `Collection` and we can call `stream` directly on `DiscoveryNodes` See elastic#83453
Collaborator
💚 Backport successful
|
arteam
added a commit
that referenced
this pull request
Feb 7, 2022
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 7, 2022
* upstream/master: [DOCS] Switch xrefs to external links (elastic#83590) [DOCS] 'features' flag added in elastic#83083 (elastic#83452) Rename ChangePolicyforIndexIT to ChangePolicyForIndexIT (elastic#83569) Fixing random_sampler tests (elastic#83549) Upgrade Checkstyle to 9.3 (elastic#83314) Make improvements to the release notes generator (elastic#83525) Cleanup DataTierAllocationDecider (elastic#83572) Upgrade jANSI dependency to 2.4.0 (elastic#83566) Speed up Name Collision Check in Metadata.Builder (elastic#83340) SQL: Add range checks to interval multiplication operation (elastic#83478) Remove DiscoveryNodes#getAllNodes (elastic#83538) Make RoutingNodes behave like a collection (elastic#83540) Remove Unused CS Listener from SecurityServerTransportInterceptor (elastic#83556)
arteam
added a commit
that referenced
this pull request
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since DiscoverNodes now extends
AbstractCollectionwe don't need a method exposingDiscoveryNodes as a
Collectionand we can callstreamdirectly onDiscoveryNodesThis also should reduce confusion between having
getAllNodesandgetNodesmethods together in the API.See #83453