TSDB: Change _tsid field to SortedDocValuesField
#83045
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
| * in compliance with, at your election, the Elastic License 2.0 or the Server | ||
| * Side Public License, v 1. | ||
| */ | ||
|
|
||
| package org.elasticsearch.index.fielddata.plain; | ||
|
|
||
| import org.apache.lucene.index.LeafReaderContext; | ||
| import org.apache.lucene.index.OrdinalMap; | ||
| import org.apache.lucene.index.SortedSetDocValues; | ||
| import org.apache.lucene.search.SortField; | ||
| import org.apache.lucene.search.SortedSetSortField; | ||
| import org.elasticsearch.common.util.BigArrays; | ||
| import org.elasticsearch.core.Nullable; | ||
| import org.elasticsearch.index.fielddata.IndexFieldData; | ||
| import org.elasticsearch.index.fielddata.IndexFieldData.XFieldComparatorSource.Nested; | ||
| import org.elasticsearch.index.fielddata.IndexFieldDataCache; | ||
| import org.elasticsearch.index.fielddata.LeafOrdinalsFieldData; | ||
| import org.elasticsearch.indices.breaker.CircuitBreakerService; | ||
| import org.elasticsearch.script.field.ToScriptField; | ||
| import org.elasticsearch.search.DocValueFormat; | ||
| import org.elasticsearch.search.MultiValueMode; | ||
| import org.elasticsearch.search.aggregations.support.ValuesSourceType; | ||
| import org.elasticsearch.search.sort.BucketedSort; | ||
| import org.elasticsearch.search.sort.SortOrder; | ||
|
|
||
| import static org.elasticsearch.index.fielddata.IndexFieldData.XFieldComparatorSource.sortMissingLast; | ||
|
|
||
| public class SortedOrdinalsIndexFieldData extends AbstractIndexOrdinalsFieldData { | ||
|
|
||
| public static class Builder implements IndexFieldData.Builder { | ||
| private final String name; | ||
| private final ToScriptField<SortedSetDocValues> toScriptField; | ||
| private final ValuesSourceType valuesSourceType; | ||
|
|
||
| public Builder(String name, ValuesSourceType valuesSourceType, ToScriptField<SortedSetDocValues> toScriptField) { | ||
| this.name = name; | ||
| this.toScriptField = toScriptField; | ||
| this.valuesSourceType = valuesSourceType; | ||
| } | ||
|
|
||
| @Override | ||
| public SortedOrdinalsIndexFieldData build(IndexFieldDataCache cache, CircuitBreakerService breakerService) { | ||
| return new SortedOrdinalsIndexFieldData(cache, name, valuesSourceType, breakerService, toScriptField); | ||
| } | ||
| } | ||
|
|
||
| public SortedOrdinalsIndexFieldData( | ||
| IndexFieldDataCache cache, | ||
| String fieldName, | ||
| ValuesSourceType valuesSourceType, | ||
| CircuitBreakerService breakerService, | ||
| ToScriptField<SortedSetDocValues> toScriptField | ||
| ) { | ||
| super(fieldName, valuesSourceType, cache, breakerService, toScriptField); | ||
| } | ||
|
|
||
| @Override | ||
| public SortField sortField(@Nullable Object missingValue, MultiValueMode sortMode, Nested nested, boolean reverse) { | ||
| SortField sortField = new SortField(getFieldName(), SortField.Type.STRING, reverse); | ||
| sortField.setMissingValue( | ||
| sortMissingLast(missingValue) ^ reverse ? SortedSetSortField.STRING_LAST : SortedSetSortField.STRING_FIRST | ||
| ); | ||
|
Contributor
There was a problem hiding this comment. Do we expect anything to be missing a
Contributor
Author
There was a problem hiding this comment. In time series indices |
||
| return sortField; | ||
| } | ||
|
|
||
| @Override | ||
| public BucketedSort newBucketedSort( | ||
| BigArrays bigArrays, | ||
| Object missingValue, | ||
| MultiValueMode sortMode, | ||
| Nested nested, | ||
| SortOrder sortOrder, | ||
| DocValueFormat format, | ||
| int bucketSize, | ||
| BucketedSort.ExtraData extra | ||
| ) { | ||
| throw new IllegalArgumentException("only supported on numeric fields"); | ||
| } | ||
|
|
||
| @Override | ||
| public LeafOrdinalsFieldData load(LeafReaderContext context) { | ||
| // Doc value fields are loaded using Lucene's DocValues#getSortedSet | ||
| // that can happily load SortedDocValues as well. | ||
| return new SortedSetBytesLeafFieldData(context.reader(), getFieldName(), toScriptField); | ||
|
Contributor
There was a problem hiding this comment. Might be worth a comment here that |
||
| } | ||
|
|
||
| @Override | ||
| public LeafOrdinalsFieldData loadDirect(LeafReaderContext context) { | ||
| return load(context); | ||
| } | ||
|
|
||
| @Override | ||
| public OrdinalMap getOrdinalMap() { | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean supportsGlobalOrdinalsMapping() { | ||
| return true; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if setting this to
SortField.Type.STRINGby default is ok.If I leave it to the default
SortField.Type.CUSTOMmethodIndexSortConfig#validateIndexSortFieldfailsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type.STRINGis correct here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type.CUSTOMmeans that it's expecting you to give it a custom FieldComparator, which we don't need. It is a horrible API from about 2004 and I keep meaning to hack it out and replace it with something less awful...