[Transform] Fix condition on which the transform stops processing buckets #82852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
fix_bucket_selector_handling
branch
from
302b1bd to
f71450f
Compare
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
benwtrent
reviewed
Jan 20, 2022
Member
benwtrent
left a comment
benwtrent
left a comment
There was a problem hiding this comment.
It would be nice to have an integration test that utilizes a bucket filter that guarantees at least one empty page, then verify that the rest of the data is pivoted.
przemekwitek
force-pushed
the
fix_bucket_selector_handling
branch
from
f71450f to
bb619e1
Compare
Contributor
Author
Done. |
przemekwitek
force-pushed
the
fix_bucket_selector_handling
branch
from
bb619e1 to
68ee222
Compare
benwtrent
approved these changes
Jan 25, 2022
Collaborator
|
Hi @przemekwitek, I've created a changelog YAML for you. |
przemekwitek
force-pushed
the
fix_bucket_selector_handling
branch
from
39bfc1f to
74c6d01
Compare
Collaborator
|
Hi @przemekwitek, I've created a changelog YAML for you. |
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Jan 26, 2022
* upstream/master: (762 commits) [DOCS] Add note to that log4j customization is outside the support scope (elastic#82668) Batch Index Settings Update Requests (elastic#82896) [DOCS] Delete pipeline containing stored script (elastic#83102) Try again to fix changelog areas after reorg (elastic#83100) Bind to non-localhost for transport in some cases (elastic#82973) [DOCS] Reuse multi-level `join` warning (elastic#82976) Remove unnecessary CopyOnWriteHashMap class (elastic#83040) Adjust changelog categories after reorg (elastic#83087) [DOCS] Fix typo in `action.destructive_requires_name` breaking change (elastic#83085) Stack Monitoring: Add Enterprise Search monitoring index templates (elastic#82743) [DOCS] Fix stored script example snippet (elastic#83056) [DOCS] Re-add network traffic para to `term` query (elastic#83047) [DOCS] Rename example stored script (elastic#83054) [ML][DOCS] Add Trained model APIs to the REST APIs index (elastic#82791) [ML] Update running process when global calendar changes (elastic#83044) [Transform] Fix condition on which the transform stops processing buckets (elastic#82852) [DOCS] Fixes field names in ML sum functions. (elastic#83048) [ML] fix NLP tokenization never_split handling around punctuation (elastic#82982) Construct dynamic updates directly via object builders (elastic#81449) Emit trace.id into audit logs (elastic#82849) ... # Conflicts: # client/rest-high-level/src/test/java/org/elasticsearch/client/IndicesClientIT.java # client/rest-high-level/src/test/java/org/elasticsearch/client/documentation/ILMDocumentationIT.java # server/src/main/java/org/elasticsearch/action/admin/indices/rollover/Condition.java # server/src/test/java/org/elasticsearch/action/admin/indices/rollover/ConditionTests.java # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/RolloverActionTests.java # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/TimeseriesLifecycleTypeTests.java # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/WaitForRolloverReadyStepTests.java
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Jan 26, 2022
przemekwitek
added a commit
that referenced
this pull request
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes transform continue processing, even if the composite agg buckets are empty (e.g.: due to restrictive bucket selector agg).
Relates #82546