Skip to content

Conversation

@russcam
Copy link
Contributor

@russcam russcam commented Jan 20, 2022

This commit removes the version_type "internal" from the rest api specs.
Support for internal versioning for optimistic concurrency control was
removed in #38254.

Since this removes values from rest api specs, it will affect any artifact that is generated from specs, for example, clients.

Other observations

  • VersionType enum still has an INTERNAL value, which might be needed for bwc?
  • SetProcessorTests randomly selects a version type which includes "internal" - this should probably also be removed.
  • IngestServiceTests randomly selects a version type which includes "internal" and "external_gt" - these should probably also be removed.

@elasticsearchmachine elasticsearchmachine added v8.1.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jan 20, 2022
@pquentin pquentin added :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >bug labels Jan 20, 2022
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jan 20, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@sethmlarson sethmlarson added the Team:Clients Meta label for clients team label Jan 24, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@arteam arteam assigned arteam and unassigned repantis Jan 31, 2022
@mark-vieira mark-vieira added v8.2.0 and removed v8.1.0 labels Feb 2, 2022
@arteam
Copy link
Contributor

arteam commented Mar 22, 2022

@elasticmachine test this please

@arteam
Copy link
Contributor

arteam commented Mar 22, 2022

@elasticmachine update branch

@elasticmachine
Copy link
Collaborator

merge conflict between base and head

@arteam
Copy link
Contributor

arteam commented Mar 22, 2022

Hey @russcam! Could you please merge/rebase your changes? I think ClientYamlSuiteRestApiTests got moved to a different directory in 0ec2290

This commit removes the version_type "internal" from the rest api specs.
Support for internal versioning for optimistic concurrency control was
removed in elastic#3825.
@russcam russcam force-pushed the remove-version-type-internal branch from f8caef1 to a83db92 Compare March 27, 2022 01:26
@russcam
Copy link
Contributor Author

russcam commented Mar 27, 2022

@arteam done

@arteam
Copy link
Contributor

arteam commented Apr 11, 2022

@elasticmachine test this please

@arteam
Copy link
Contributor

arteam commented Apr 11, 2022

@elasticmachine generate changelog

@arteam
Copy link
Contributor

arteam commented Apr 19, 2022

@elasticmachine test this please

@arteam
Copy link
Contributor

arteam commented May 23, 2022

Hey @russcam. Sorry for getting back to you late. Unfortunately, this change would qualify as a breaking change under the Elasticsearch guidelines. We try to avoid introducing breaking changes in Elasticsearch unless there is a considerable benefit in doing so. Currently, removing the "internal" version_type from the specs wouldn't be a considerable improvement for users who try to use it (they would get a runtime error), but it can break users who specify version_type: internal by accident or by using some older SDK versions. Thanks!

@arteam arteam closed this May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Clients Meta label for clients team Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants