-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Remove version_type "internal" from rest api specs #82842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Pinging @elastic/clients-team (Team:Clients) |
|
@elasticmachine test this please |
|
@elasticmachine update branch |
|
merge conflict between base and head |
This commit removes the version_type "internal" from the rest api specs. Support for internal versioning for optimistic concurrency control was removed in elastic#3825.
f8caef1 to
a83db92
Compare
|
@arteam done |
|
@elasticmachine test this please |
|
@elasticmachine generate changelog |
|
@elasticmachine test this please |
|
Hey @russcam. Sorry for getting back to you late. Unfortunately, this change would qualify as a breaking change under the Elasticsearch guidelines. We try to avoid introducing breaking changes in Elasticsearch unless there is a considerable benefit in doing so. Currently, removing the |
This commit removes the version_type
"internal"from the rest api specs.Support for internal versioning for optimistic concurrency control was
removed in #38254.
Since this removes values from rest api specs, it will affect any artifact that is generated from specs, for example, clients.
Other observations
VersionTypeenum still has anINTERNALvalue, which might be needed for bwc?SetProcessorTestsrandomly selects a version type which includes"internal"- this should probably also be removed.IngestServiceTestsrandomly selects a version type which includes"internal"and"external_gt"- these should probably also be removed.