Skip to content

Make wildcard accessible from the scripting field API #82763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 18, 2022
Merged

Make wildcard accessible from the scripting field API #82763

merged 5 commits into from
Jan 18, 2022

Conversation

@jdconrad
Copy link
Contributor

@jdconrad jdconrad commented Jan 18, 2022

This adds the mapped typed wildcard to the scripting fields API.

API:

    iterator()
    get(String default)
    get(String default, int index)

@jdconrad jdconrad added >enhancement :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v8.1.0 labels Jan 18, 2022
@jdconrad jdconrad requested a review from stu-elastic January 18, 2022 20:00
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jan 18, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 18, 2022

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jan 18, 2022

Hi @jdconrad, I've created a changelog YAML for you.

@jdconrad jdconrad mentioned this pull request Jan 18, 2022
Open
49 tasks
stu-elastic
stu-elastic approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@stu-elastic stu-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, good to go when addressed.

@jdconrad
Copy link
Contributor Author

jdconrad commented Jan 18, 2022

Thanks for the review. Will commit as soon as CI passes.

@jdconrad jdconrad merged commit 0a51d32 into elastic:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stu-elastic stu-elastic stu-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement Team:Core/Infra Meta label for core/infra team v8.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jdconrad @elasticmachine @elasticsearchmachine @stu-elastic