Add half float mapping to the scripting fields API #82294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
>enhancement
:Core/Infra/Scripting
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
|
Hi @jdconrad, I've created a changelog YAML for you. |
49 tasks
stu-elastic
reviewed
Jan 6, 2022
| } | ||
|
|
||
| class org.elasticsearch.script.field.HalfFloatDocValuesField @dynamic_type { | ||
| float get(double) |
Contributor
There was a problem hiding this comment.
Can you add a note explaining why this takes a double but returns a float.
Contributor
Author
|
@stu-elastic Thanks for the review. Will commit as soon as CI passes. |
Contributor
Author
|
Due to the casting between floats and doubles, I updated the test to use close_to instead of match. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the mapped type half float the scripting fields API. This also adds additional methods for
asDoubleto reach parity with old-styledocaccess.