Watcher fix ActivateWatchTests #82157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelandis
added
>test
elasticmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
💚 Backport successful
|
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Jan 4, 2022
This commit attempts to fix a set of Watcher tests that can fail due to unexpected execution of Watches after Watcher has been stopped. The theory here is that a Watch can be queued but not fully executed then Watcher is shutdown, the test does some clean up, then the queued Watch finishes execution and causes some some additional cleanup to fail. The change here ensures that when Watcher is stopped from AbstractWatcherIntegrationTestCase that it will also wait until there are no more current Watches executing. closes elastic#66495
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 4, 2022
This commit attempts to fix a set of Watcher tests that can fail due to unexpected execution of Watches after Watcher has been stopped. The theory here is that a Watch can be queued but not fully executed then Watcher is shutdown, the test does some clean up, then the queued Watch finishes execution and causes some some additional cleanup to fail. The change here ensures that when Watcher is stopped from AbstractWatcherIntegrationTestCase that it will also wait until there are no more current Watches executing. closes #66495
astefan
pushed a commit
to astefan/elasticsearch
that referenced
this pull request
Jan 7, 2022
This commit attempts to fix a set of Watcher tests that can fail due to unexpected execution of Watches after Watcher has been stopped. The theory here is that a Watch can be queued but not fully executed then Watcher is shutdown, the test does some clean up, then the queued Watch finishes execution and causes some some additional cleanup to fail. The change here ensures that when Watcher is stopped from AbstractWatcherIntegrationTestCase that it will also wait until there are no more current Watches executing. closes elastic#66495
astefan
pushed a commit
to astefan/elasticsearch
that referenced
this pull request
Jan 7, 2022
This commit attempts to fix a set of Watcher tests that can fail due to unexpected execution of Watches after Watcher has been stopped. The theory here is that a Watch can be queued but not fully executed then Watcher is shutdown, the test does some clean up, then the queued Watch finishes execution and causes some some additional cleanup to fail. The change here ensures that when Watcher is stopped from AbstractWatcherIntegrationTestCase that it will also wait until there are no more current Watches executing. closes elastic#66495
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit attempts to fix a set of Watcher tests that can
fail due to unexpected execution of Watches after Watcher has been stopped.
The theory here is that a Watch can be queued but not fully executed
then Watcher is shutdown, the test does some clean up, then the
queued Watch finishes execution and causes some some additional cleanup
to fail.
The change here ensures that when Watcher is stopped from
AbstractWatcherIntegrationTestCasethat it will also wait until there are no more current Watches executing.
closes #66495