[DOCS] Archived settings block other setting updates #82069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrodewig
added
>docs
elasticmachine
added
Team:Docs
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
j-bennet
approved these changes
Dec 27, 2021
j-bennet
left a comment
j-bennet
left a comment
There was a problem hiding this comment.
Looks great! 👍 I really hope the inconsistent behavior can be fixed in the future though, besides only being clarified in the documentation.
| Removing archived index settings requires a reindex after the upgrade. However, | ||
| reindexing can be resource intensive. Because {es} ignores archived settings, | ||
| you can safely leave them in place if wanted. | ||
| Removing an index's archived index settings requires a <<docs-reindex,reindex>>. |
Contributor
Author
|
@DaveCTurner @gwbrown Do one of you mind taking a look at this PR at your convenience? Thank you! |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
gwbrown
approved these changes
Jan 26, 2022
Contributor
gwbrown
left a comment
gwbrown
left a comment
There was a problem hiding this comment.
LGTM, thanks! And again, apologies for the delay!
Contributor
Author
|
Thanks @gwbrown! |
This was referenced Jan 26, 2022
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 26, 2022
**Changes:** * Notes that archived cluster settings block cluster setting updates. Previously, the docs stated that ES ignored archived cluster settings. * Notes that archived index settings can block index settings updates. For example, it blocks `index.hidden` but not `number_of_replicas`. Previously, the docs stated that you could safely ignore archived index settings. Relates #78351 Closes #61175 (cherry picked from commit 47d45d0)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 26, 2022
**Changes:** * Notes that archived cluster settings block cluster setting updates. Previously, the docs stated that ES ignored archived cluster settings. * Notes that archived index settings can block index settings updates. For example, it blocks `index.hidden` but not `number_of_replicas`. Previously, the docs stated that you could safely ignore archived index settings. Relates #78351 Closes #61175 (cherry picked from commit 47d45d0)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 26, 2022
**Changes:** * Notes that archived cluster settings block cluster setting updates. Previously, the docs stated that ES ignored archived cluster settings. * Notes that archived index settings can block index settings updates. For example, it blocks `index.hidden` but not `number_of_replicas`. Previously, the docs stated that you could safely ignore archived index settings. Relates #78351 Closes #61175 (cherry picked from commit 47d45d0)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 26, 2022
**Changes:** * Notes that archived cluster settings block cluster setting updates. Previously, the docs stated that ES ignored archived cluster settings. * Notes that archived index settings can block index settings updates. For example, it blocks `index.hidden` but not `number_of_replicas`. Previously, the docs stated that you could safely ignore archived index settings. Relates #78351 Closes #61175 (cherry picked from commit 47d45d0)
This was referenced Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
index.hiddenbut notnumber_of_replicas. Previously, the docs stated that you could safely ignore archived index settings.Preview
https://elasticsearch_82069.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/archived-settings.html
Relates #78351
Closes #61175