[Transform] Prevent stopping of transforms due to threadpool limitation #81912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the indexer threadpool was only used on start. fixes elastic#81796
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
przemekwitek
approved these changes
Dec 20, 2021
| @Override | ||
| public boolean maybeTriggerAsyncJob(long now) { | ||
| boolean triggered; | ||
| // threadpool: trigger_engine_scheduler if triggered from the scheduler |
Contributor
There was a problem hiding this comment.
What is the alternative (if not triggered from the scheduler)?
Author
There was a problem hiding this comment.
this is also called by the transform task when it starts, e.g. as a result of _start or if the transform re-initializes due to a task re-location (failover or upgrade).
Author
|
@elasticmachine update branch |
Author
|
@elasticmachine update branch |
hendrikmuhs
pushed a commit
to hendrikmuhs/elasticsearch
that referenced
this pull request
Feb 4, 2022
…on (elastic#81912) remove the indexer threadpool and use the generic threadpool instead(The indexer threadpool was only used on start) fixes elastic#81796
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the indexer threadpool and use the generic threadpool instead(The indexer threadpool was only used on start)
fixes #81796