Skip to content

[6.8.22] Upgrade to log4j 2.17.0 #81906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 18, 2021
Merged

[6.8.22] Upgrade to log4j 2.17.0 #81906

merged 6 commits into from
Dec 18, 2021

Conversation

@ChrisHegarty
Copy link
Contributor

@ChrisHegarty ChrisHegarty commented Dec 18, 2021

Backport of:

@ChrisHegarty ChrisHegarty self-assigned this Dec 18, 2021
pgomulka
pgomulka approved these changes Dec 18, 2021
View reviewed changes
Copy link
Contributor

@pgomulka pgomulka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costin costin self-requested a review December 18, 2021 19:56
costin
costin approved these changes Dec 18, 2021
View reviewed changes
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHegarty ChrisHegarty changed the title [6.8] Upgrade to log4j 2.17.0 [6.8.22] Upgrade to log4j 2.17.0 Dec 18, 2021
@ChrisHegarty ChrisHegarty merged commit 71fcb50 into elastic:6.8 Dec 18, 2021
@ChrisHegarty ChrisHegarty deleted the 6.8_log4j_2.17.0 branch December 18, 2021 21:07
@boicehuang
Copy link
Contributor

boicehuang commented Dec 21, 2021 •
edited
Loading

hello, I found "log4j-core-2.‎17.0.jar.sha1‎" should be "fe6e7a32c1228884b9691a744f953a55d0dd8ead", not "587127e2f8c5daaef9ba3806848675a1652959d3"

It will lead to check sha1 failure

https://github.com/elastic/elasticsearch/blob/v6.8.22/server/licenses/log4j-core-2.17.0.jar.sha1#L1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@costin costin costin approved these changes

+1 more reviewer

@pgomulka pgomulka pgomulka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ChrisHegarty ChrisHegarty

Labels

backport v6.8.22

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ChrisHegarty @boicehuang @costin @pgomulka @elasticsearchmachine