Add a geo point field for the scripting fields api #81395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
>enhancement
:Core/Infra/Scripting
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
49 tasks
Collaborator
|
Hi @jdconrad, I've created a changelog YAML for you. |
stu-elastic
reviewed
Dec 6, 2021
modules/lang-painless/src/main/resources/org/elasticsearch/painless/org.elasticsearch.txt
Show resolved
Hide resolved
stu-elastic
reviewed
Dec 6, 2021
server/src/main/java/org/elasticsearch/script/field/GeoPointDocValuesField.java
Show resolved
Hide resolved
stu-elastic
approved these changes
Dec 6, 2021
Contributor
stu-elastic
left a comment
stu-elastic
left a comment
There was a problem hiding this comment.
Request and question. Good work.
Contributor
Author
|
@stu-elastic Thanks for the review! Will commit as soon as CI passes. |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/docs skiplinkcheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a geo point(s) field for the scripting fields api. This field only supports get(default), get(index, default), and iterator right now. This also adds the ability to create new a GeoPoint through the allow list, so users can specify a default that makes sense. It does not include reset as this field currently does not wrap the data to be read-only.
We should go through and re-evaluate the utility methods we want to support for geo in general at this point.