_tier_preference docs changes for 8.0 #81389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and rewrite the page slightly -- there's only _tier_preference so we don't have to talk about 'settings' or 'attributes', it's just the one.
So reword this section to more strongly indicate that you'll need to disable it if you don't want it -- it's not enough to 'merely' specify some manual allocation.
joegallo
added
v8.0.0
v8.1.0
:Data Management/ILM+SLM
'also' made more sense before the preceding paragraph was removed.
elasticmachine
added
Team:Docs
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
joegallo
added
>non-issue
and removed
>docs
dakrone
approved these changes
Dec 6, 2021
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
LGTM, I left one really minor comment that is optional.
docs/reference/datatiers.asciidoc
Outdated
| By default, this action is automatically injected in every phase. | ||
| You can explicitly specify the migrate action to override the default behavior, | ||
| or use the <<ilm-allocate, allocate action>> to manually specify allocation rules. | ||
| You can explicitly specify the migrate action to disable automatic migration, |
Member
There was a problem hiding this comment.
I think it'd be useful to say "specify the migrate action with 'enabled': false", because just manually specifying the migrate action doesn't actually disable it.
Contributor
Author
There was a problem hiding this comment.
Will do! I was already on the fence about exactly that, so thanks for giving me a reason to choose one way over the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #76147 and particularly #79751
Remove some places that mention setting the
_tier_preferencetonull, as well as conditionals around the injection of themigrateaction -- on 8.0, newly created indices will always get either an explicitly-set or defaulted_tier_preference, and themigrateaction is always inserted.Also fixes some vestigial documentation that still references the
_tierfilters which had already been removed from 8.0 (see #73074).