[TEST] Wait for async LDAP search to finish #81197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDAP SDK has a race condition where closing a connection while an async search is still executing could lead to a Timer thread being orphaned. See: pingidentity/ldapsdk#120 This commit changes SearchGroupsResolverInMemoryTests so that it waits for the pending async search to complete (or timeout) before returning. This ensures that when the close the connection the Timer thread is cancelled (and stays cancelled).
tvernum
added
>test
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
ywangd
approved these changes
Dec 1, 2021
Member
ywangd
left a comment
ywangd
left a comment
There was a problem hiding this comment.
LGTM
Thanks for digging into this issue. It's a great finding!
...test/java/org/elasticsearch/xpack/security/authc/ldap/SearchGroupsResolverInMemoryTests.java
Outdated
Show resolved
Hide resolved
tvernum
added
the
auto-merge-without-approval
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Dec 2, 2021
LDAP SDK has a race condition where closing a connection while an async search is still executing could lead to a Timer thread being orphaned. See: pingidentity/ldapsdk#120 This commit changes SearchGroupsResolverInMemoryTests so that it waits for the pending async search to complete (or timeout) before returning. This ensures that when the close the connection the Timer thread is cancelled (and stays cancelled). Resolves: elastic#80305
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 2, 2021
LDAP SDK has a race condition where closing a connection while an async search is still executing could lead to a Timer thread being orphaned. See: pingidentity/ldapsdk#120 This commit changes SearchGroupsResolverInMemoryTests so that it waits for the pending async search to complete (or timeout) before returning. This ensures that when the close the connection the Timer thread is cancelled (and stays cancelled). Resolves: #80305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LDAP SDK has a race condition where closing a connection while an
async search is still executing could lead to a Timer thread being
orphaned.
See: pingidentity/ldapsdk#120
This commit changes SearchGroupsResolverInMemoryTests so that it waits
for the pending async search to complete (or timeout) before
returning. This ensures that when the close the connection the Timer
thread is cancelled (and stays cancelled).
Resolves: #80305