Script: fields API for byte, double, float, integer, long, short #81126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds DocValuesField for byte, double, float, integer, long and short The integral types implement ScriptDocValues.Supplier<Long> while the floating point types implement ScriptDocValues.Supplier<Double>. Refs: elastic#79105
stu-elastic
added
:Core/Infra/Scripting
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
This was referenced Nov 29, 2021
jdconrad
approved these changes
Nov 30, 2021
Contributor
jdconrad
left a comment
jdconrad
left a comment
There was a problem hiding this comment.
This looks great! Big step forward :) for the scripting fields API. I left a few minor requests for some comment/JavaDoc clean up.
...ang-painless/src/yamlRestTest/resources/rest-api-spec/test/painless/50_script_doc_values.yml
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/script/field/ByteDocValuesField.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/script/field/ByteDocValuesField.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/script/field/DoubleDocValuesField.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/script/field/ByteDocValuesField.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/script/field/LongDocValuesField.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/script/field/LongDocValuesField.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/script/field/ShortDocValuesField.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/script/field/ShortDocValuesField.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/script/field/ShortDocValuesField.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integral types implement
ScriptDocValues.Supplier<Long>while thefloating point types implement
ScriptDocValues.Supplier<Double>.Refs: #79105