Fix split package org.apache.lucene.queries #81043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
reviewed
Nov 25, 2021
Contributor
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
LGTM. Not sure why we have our own copy of BlendedTermQuery, I'll see if I can follow that up.
romseygeek
approved these changes
Nov 25, 2021
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow for the future modularization of Elasticsearch with Java Modules, there are a number preparatory tasks that need be completed. This is one part of one such task: eliminate split packages.
This PR proposes to move three classes from
org.apache.lucene.queriesto the already existingorg.elasticsearch.lucene.queriespackage, thus avoiding the split package with lucene. It would appear that package-private access was needed when these classes were originally conceived, but this is no longer the case.It's worth noting that prior to this change
org.apache.lucene.queries.BinaryTermQuerywas being "hidden" by the ES version of this class. I'm not sure that this is all that significant, but certainly a little odd. Maybe this hints at a possible future opportunity to do further clean up and consolidation in this area.relates #78166