Skip to content

Conversation

@hendrikmuhs
Copy link

do not fail a running transform if upgrader rewrites state inbetween

fixes #80073

Severity: This fixes a rare scenario, probably unrealistic in production: upgrade must be called directly after a rolling upgrade has finished, which is only possible if upgrade is called by automation (the issue has been triggered in CI)
Risk: medium, small change
non-issue: The upgrade endpoint has not been part of a release yet

Note: the 7.16 backport should additionally unmute 99d6a93

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hendrikmuhs hendrikmuhs added the auto-backport Automatically create backport pull requests when merged label Nov 10, 2021
@hendrikmuhs hendrikmuhs merged commit 4431412 into elastic:master Nov 10, 2021
@hendrikmuhs hendrikmuhs deleted the transform-upgrade-#80073 branch November 10, 2021 14:29
hendrikmuhs pushed a commit to hendrikmuhs/elasticsearch that referenced this pull request Nov 10, 2021
…pgrade (elastic#80579)

do not fail a running transform if upgrader rewrites state inbetween

fixes elastic#80073
hendrikmuhs pushed a commit to hendrikmuhs/elasticsearch that referenced this pull request Nov 10, 2021
…pgrade (elastic#80579)

do not fail a running transform if upgrader rewrites state inbetween

fixes elastic#80073
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.0
7.16

elasticsearchmachine pushed a commit that referenced this pull request Nov 10, 2021
…pgrade (#80579) (#80601)

do not fail a running transform if upgrader rewrites state inbetween

fixes #80073
elasticsearchmachine pushed a commit that referenced this pull request Nov 10, 2021
…uster upgrade (#80579) (#80602)

* [Transform] Fix issue if upgrade runs right after a rolling cluster upgrade (#80579)

do not fail a running transform if upgrader rewrites state inbetween

fixes #80073

* reactivate test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :ml/Transform Transform >non-issue Team:ML Meta label for the ML team v7.16.0 v8.0.0-rc2 v8.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] TransformSurvivesUpgradeIT testTransformRollingUpgrade failing

5 participants