Prevent NullPointerException in SourceConfirmedTextQuery #80472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>bug
:Search/Search
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
jpountz
approved these changes
Nov 8, 2021
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Nov 8, 2021
Prevents a npe when the field that does not exists in the index
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Nov 8, 2021
Prevents a npe when the field that does not exists in the index
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 8, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a
SourceConfirmedTextQuerywith a field that does not exists in the index, then the query throws a NullPointerException. This is due to the fact that in that case the callsearcher.collectionStatistics(field)returns a null which causes the exception. This PR handles that situation.fixes #80419