remove nullable annotation in IndexShard constructor #80468
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v8.1.0
external-contributor
Member
|
This change is clearly correct, thanks @mushao999, but I think that someone on @elastic/es-distributed should review and shepherd the change through the process. |
jasontedor
added
the
:Distributed Indexing/Distributed
elasticmachine
added
the
Team:Distributed (Obsolete)
Contributor
Author
|
@jasontedor Please help to ping someone who can review and merge this PR. This small PR stays too long. Thanks |
arteam
added
auto-backport
arteam
approved these changes
Jan 10, 2022
Contributor
arteam
left a comment
arteam
left a comment
There was a problem hiding this comment.
LGTM! I can confirm that EngineFactory is indeed can't be null
Contributor
|
Thank you @mushao999 for the contribution! |
arteam
removed
v8.0.0
auto-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #26827, @jasontedor enabled engine factory to be pluggable.
engineFactoryparameter of IndexShard constructor became not nullable, so@nullableannotation for this parameter was removed in that PR.However,
@nullableannotaion was still there after the PR was merged, maybe a merge operation mistake.This PR remove the
@nullableannotaion ofengineFactoryin IndexShard constructor, in order to solve the conflict between@nullableannotaion andObjects.requireNonNull(engineFactory).