Better error message for long keys in flattened fields #80433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
>enhancement
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
romseygeek
approved these changes
Nov 8, 2021
Contributor
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
LGTM, nice usability improvement.
Member
Author
|
@elasticsearchmachine run elasticsearch-ci/rest-compatibility |
Member
Author
|
@elasticmachine update branch |
cbuescher
added
the
auto-backport
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Nov 8, 2021
When a keyed ´flattened` field that is composed of both the fields key, a separator and the actual value, exceeds Lucenes term limit, the user currently gets a confusing IAE that among other things only mentions the fields `_keyed` subfield as the source of the offending long term. Since it might be both key and value that might trip this we can check earlier and throw a nices IAE that reports both key and value lengths and the prefix of the offending key. Closes elastic#78248
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Nov 8, 2021
When a keyed ´flattened` field that is composed of both the fields key, a separator and the actual value, exceeds Lucenes term limit, the user currently gets a confusing IAE that among other things only mentions the fields `_keyed` subfield as the source of the offending long term. Since it might be both key and value that might trip this we can check earlier and throw a nices IAE that reports both key and value lengths and the prefix of the offending key. Closes elastic#78248
Collaborator
cbuescher
pushed a commit
that referenced
this pull request
Nov 8, 2021
When a keyed ´flattened` field that is composed of both the fields key, a separator and the actual value, exceeds Lucenes term limit, the user currently gets a confusing IAE that among other things only mentions the fields `_keyed` subfield as the source of the offending long term. Since it might be both key and value that might trip this we can check earlier and throw a nices IAE that reports both key and value lengths and the prefix of the offending key. Closes #78248
cbuescher
pushed a commit
that referenced
this pull request
Nov 8, 2021
#80487) When a keyed ´flattened` field that is composed of both the fields key, a separator and the actual value, exceeds Lucenes term limit, the user currently gets a confusing IAE that among other things only mentions the fields `_keyed` subfield as the source of the offending long term. Since it might be both key and value that might trip this we can check earlier and throw a nices IAE that reports both key and value lengths and the prefix of the offending key. Closes #78248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a keyed
flattenedfield that is composed of both the fields key, a separatorand the actual value, exceeds Lucenes term limit, the user currently gets a confusing
IAE that among other things only mentions the fields
_keyedsubfield as the sourceof the offending long term. Since it might be both key and value that might trip this
we can check earlier and throw a nices IAE that reports both key and value lengths
and the prefix of the offending key.
Closes #78248