[ML] fixing bug when returning multi-doc compressed model definitions #80377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>non-issue
:ml
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
benwtrent
force-pushed
the
feature/ml-fix-compressed-model-definition-bug
branch
from
9e4d6bd to
2ccd83f
Compare
przemekwitek
approved these changes
Nov 5, 2021
.../ml/src/main/java/org/elasticsearch/xpack/ml/inference/persistence/TrainedModelProvider.java
Show resolved
Hide resolved
davidkyle
approved these changes
Nov 5, 2021
Member
davidkyle
left a comment
davidkyle
left a comment
There was a problem hiding this comment.
LGTM thanks for adding the tests
benwtrent
added
the
auto-merge-without-approval
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Nov 5, 2021
…elastic#80377) When deserializing multi-doc compressed model definitions, I periodically receive weird errors regarding bytes references. Turns out, when we parse the individual bytes references we parse them into `ByteArrays` which satisfy the `bytes()` method. But, `CompositeBytesReference`, when there are multiple BytesReferences, does not allow `bytes()` to be called.
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 5, 2021
…#80377) (#80414) When deserializing multi-doc compressed model definitions, I periodically receive weird errors regarding bytes references. Turns out, when we parse the individual bytes references we parse them into `ByteArrays` which satisfy the `bytes()` method. But, `CompositeBytesReference`, when there are multiple BytesReferences, does not allow `bytes()` to be called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deserializing multi-doc compressed model definitions, I periodically receive weird errors regarding bytes references.
Turns out, when we parse the individual bytes references we parse them into
ByteArrayswhich satisfy thebytes()method.But,
CompositeBytesReference, when there are multiple BytesReferences, does not allowbytes()to be called.