Skip to content

Conversation

@stu-elastic
Copy link
Contributor

@stu-elastic stu-elastic commented Oct 28, 2021

Add support for boolean fields with the following public API:

  • boolean get(boolean)
    Return the first boolean or the given default

  • boolean get(int, boolean)
    Return the boolean at index or the given default

  • Iterator<Boolean> Iterator()
    Return a copy of the array of booleans, may return a zero length array.

Refs: #79105

Add support for boolean fields with the following public API:

* `boolean getValue(boolean)`
  Return the first boolean or the given default

* `boolean getValue(int, boolean)`
  Return the boolean at index or the given default

* `boolean[] getValues()`
  Return a copy of the array of booleans, may return a zero length array.

Refs: elastic#79105
@stu-elastic stu-elastic added >enhancement :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v8.1.0 labels Oct 28, 2021
@stu-elastic stu-elastic requested a review from jdconrad October 28, 2021 20:23
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Oct 28, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stu-elastic
Copy link
Contributor Author

@elasticmachine update branch

@stu-elastic stu-elastic merged commit 06202d6 into elastic:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement Team:Core/Infra Meta label for core/infra team v8.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants