Skip to content

Conversation

@jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Oct 28, 2021

Removes testenv annotations and related code. These annotations originally let you skip x-pack snippet tests in the docs. However, that's no longer possible.

Relates to #79309, #31619

@jrodewig jrodewig added :Delivery/Build Build or test infrastructure >docs General docs changes v7.15.2 v7.16.1 v8.0.0-beta1 >non-issue labels Oct 28, 2021
@jrodewig jrodewig marked this pull request as ready for review October 28, 2021 16:21
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Delivery Meta label for Delivery team labels Oct 28, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@jrodewig jrodewig requested a review from breskeby October 28, 2021 16:21
@jrodewig
Copy link
Contributor Author

jrodewig commented Oct 29, 2021

After taking a closer look and running some local tests, I'm pretty sure that testenv doesn't do anything. I pushed 571090a to remove the supporting code and remaining annotations.

@jrodewig jrodewig changed the title [DOCS] Remove unneeded docs testenv annotations [DOCS] Remove unneeded testenv annotations for doc snippet tests Oct 29, 2021
@jrodewig jrodewig changed the title [DOCS] Remove unneeded testenv annotations for doc snippet tests [DOCS] Remove unneeded testenv annotations from doc snippet tests Oct 29, 2021
@jrodewig jrodewig changed the title [DOCS] Remove unneeded testenv annotations from doc snippet tests [DOCS] Remove testenv annotations from doc snippet tests Oct 29, 2021
@jrodewig
Copy link
Contributor Author

@elasticmachine update branch

@jrodewig
Copy link
Contributor Author

@elasticmachine update branch

@jrodewig jrodewig requested review from a team and nik9000 and removed request for breskeby November 5, 2021 21:34
Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig
Copy link
Contributor Author

jrodewig commented Nov 5, 2021

Thanks @mark-vieira!

@jrodewig jrodewig merged commit f56a0f4 into elastic:master Nov 5, 2021
@jrodewig jrodewig deleted the docs__remove-xpack-annotation-yaml branch November 5, 2021 22:38
elasticsearchmachine pushed a commit that referenced this pull request Nov 5, 2021
…80457)

Removes `testenv` annotations and related code. These annotations originally let you skip x-pack snippet tests in the docs. However, that's no longer possible.

Relates to #79309, #31619
elasticsearchmachine pushed a commit that referenced this pull request Nov 5, 2021
…80459)

Removes `testenv` annotations and related code. These annotations originally let you skip x-pack snippet tests in the docs. However, that's no longer possible.

Relates to #79309, #31619
# Conflicts:
#	docs/reference/ingest/range-enrich-policy-type-ex.asciidoc
#	docs/reference/migration/apis/feature_upgrade.asciidoc
#	docs/reference/ml/df-analytics/apis/get-trained-model-deployment-stats.asciidoc
#	docs/reference/ml/df-analytics/apis/infer-trained-model-deployment.asciidoc
#	docs/reference/ml/df-analytics/apis/put-trained-model-definition-part.asciidoc
#	docs/reference/ml/df-analytics/apis/put-trained-model-vocabulary.asciidoc
#	docs/reference/ml/df-analytics/apis/start-trained-model-deployment.asciidoc
#	docs/reference/ml/df-analytics/apis/stop-trained-model-deployment.asciidoc
#	docs/reference/slm/apis/slm-delete.asciidoc
#	docs/reference/slm/apis/slm-execute-retention.asciidoc
#	docs/reference/slm/apis/slm-execute.asciidoc
#	docs/reference/slm/apis/slm-get-status.asciidoc
#	docs/reference/slm/apis/slm-get.asciidoc
#	docs/reference/slm/apis/slm-start.asciidoc
#	docs/reference/slm/apis/slm-stats.asciidoc
#	docs/reference/slm/apis/slm-stop.asciidoc
#	docs/reference/sql/endpoints/client-apps/tableau-desktop.asciidoc
#	docs/reference/sql/endpoints/client-apps/tableau-server.asciidoc
#	docs/reference/transform/apis/upgrade-transforms.asciidoc
elasticsearchmachine pushed a commit that referenced this pull request Nov 5, 2021
…80458)

Removes `testenv` annotations and related code. These annotations originally let you skip x-pack snippet tests in the docs. However, that's no longer possible.

Relates to #79309, #31619
# Conflicts:
#	docs/reference/ml/df-analytics/apis/get-trained-model-deployment-stats.asciidoc
#	docs/reference/ml/df-analytics/apis/infer-trained-model-deployment.asciidoc
#	docs/reference/ml/df-analytics/apis/put-trained-model-definition-part.asciidoc
#	docs/reference/ml/df-analytics/apis/put-trained-model-vocabulary.asciidoc
#	docs/reference/ml/df-analytics/apis/start-trained-model-deployment.asciidoc
#	docs/reference/ml/df-analytics/apis/stop-trained-model-deployment.asciidoc
#	docs/reference/slm/apis/slm-delete.asciidoc
#	docs/reference/slm/apis/slm-execute-retention.asciidoc
#	docs/reference/slm/apis/slm-execute.asciidoc
#	docs/reference/slm/apis/slm-get-status.asciidoc
#	docs/reference/slm/apis/slm-get.asciidoc
#	docs/reference/slm/apis/slm-start.asciidoc
#	docs/reference/slm/apis/slm-stats.asciidoc
#	docs/reference/slm/apis/slm-stop.asciidoc
#	docs/reference/sql/endpoints/client-apps/tableau-desktop.asciidoc
#	docs/reference/sql/endpoints/client-apps/tableau-server.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Delivery/Build Build or test infrastructure >docs General docs changes >non-issue Team:Delivery Meta label for Delivery team Team:Docs Meta label for docs team v7.15.2 v7.16.0 v8.0.0-beta1 v8.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants