Make Index Settings Update CS Task Cheaper #79883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to rebuild the routing table (and thus nodes) unless the replica count changed. Also, less important, don't use a new blocks object if nothing changed about the blocks.
original-brownbear
added
>non-issue
:Distributed Coordination/Cluster Coordination
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
Author
|
Jenkins run elasticsearch-ci/packaging-tests-unix-sample |
…ting-table-redundantly
henningandersen
approved these changes
Oct 27, 2021
Contributor
henningandersen
left a comment
henningandersen
left a comment
There was a problem hiding this comment.
LGTM.
Perhaps add a test that the routing table stays the same for some settings update?
Contributor
Author
Can't really do a nice test here (yet). There's still #79860 and then a follow-up to that between us and not rebuilding the routing table needlessly here. I'll add a clean assertion + test into the follow-up after #79860 :) (incoming today probably) |
Contributor
Author
|
Thanks Henning! |
original-brownbear
deleted the
do-not-rebuild-routing-table-redundantly
branch
original-brownbear
restored the
do-not-rebuild-routing-table-redundantly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to rebuild the routing table (and thus nodes) unless the
replica count changed.
Also, less important, don't use a new blocks object if nothing changed
about the blocks.
relates #77466