[Transform] add rolling upgrade tests for upgrade endpoint #79721
Conversation
hendrikmuhs
added
>test
|
Pinging @elastic/ml-core (Team:ML) |
|
The test fails because it upgrades 8.0 to 8.0. This looks like an error in the test setup. I will investigate, however I consider this benign, once 8.0 is branched off, I expect this problem to disappear. |
|
^ @elastic/es-delivery FYI, see my last comment. I am not sure if you want to do something about it or if you suggest to wait for the 8.0 branch. |
|
It's deliberate that the BWC tests run with the "old" cluster starting on the same version as the "new" cluster - see #39102. I guess what this shows is that no other functionality that refuses to run in mixed version clusters has this aspect tested by the YAML rolling upgrade tests. For all these other features the refusal to run in mixed version clusters must be tested only by unit tests or by integration tests written in Java that can assert on more complex combinations of things. |
hendrikmuhs
force-pushed
the
transform-upgrading-rrtest
branch
from
e3c1f83 to
bc57eb4
Compare
| client().performRequest(waitForYellow); | ||
| verifyContinuousTransformHandlesData(3); | ||
| verifyUpgrade(); | ||
| cleanUpTransforms(); |
There was a problem hiding this comment.
sorry for reformat, verifyUpgradeFailsIfMixedCluster and verifyUpgrade are the 2 methods I added
| Response response = client().performRequest(upgradeTransformRequest); | ||
| assertEquals(200, response.getStatusLine().getStatusCode()); | ||
| } | ||
|
|
There was a problem hiding this comment.
^ above are the 2 new methods
|
Yep, what @droberts195 said. We "upgrade" from the current version to the current version to effectively simulate a node restart. We should probably make this scenario more explicit though. |
|
@elasticmachine update branch |
…9721) add rolling upgrade tests for upgrade endpoint
…9721) add rolling upgrade tests for upgrade endpoint
…80012) add rolling upgrade tests for upgrade endpoint Co-authored-by: Elastic Machine <[email protected]>
…formance * upstream/master: (153 commits) [ML] update truncation default & adding field output when input is truncated (elastic#79942) [ML] stop using isAllowedByLicense for model license checks (elastic#79908) [ML] Retain built-in ML roles granting Kibana privileges (elastic#80014) [Transform] remove old mixed cluster BWC layers, not required for 8x (elastic#79927) Increase test timeout for CoordinatorTests testAllSearchesExecuted [Transform] add rolling upgrade tests for upgrade endpoint (elastic#79721) [ML] Update trained model docs for truncate parameter for bert tokenization (elastic#79652) `CoordinatorTests` sometimes needs three term bumps (elastic#79574) [ML] Account for service being triggered twice in tests (elastic#80000) SearchContext: remove unused variable (elastic#79917) Revert "Deprecate resolution loss on date field (elastic#78921)" (elastic#79914) Re-enable GeoIpDownloaderIT#testStartWithNoDatabases() (elastic#79907) Fix SnapshotBasedIndexRecoveryIT#testSeqNoBasedRecoveryIsUsedAfterPrimaryFailOver (elastic#79469) Fix RecoverySourceHandlerTests (elastic#79546) SQL: stabilize SqlSearchPageTimeoutIT (elastic#79928) Wait 3 seconds for the server to reload trust (elastic#79778) Skip automatically preserved request headers when rewriting (elastic#79973) Check whether stdout is a real console (elastic#79882) Convert remote license checker to use LicensedFeature (elastic#79876) Miscellaneous fixes for LDAP SDK v6 upgrade (elastic#79891) ... # Conflicts: # libs/x-content/src/main/java/org/elasticsearch/xcontent/support/filtering/FilterPath.java # libs/x-content/src/test/java/org/elasticsearch/xcontent/support/filtering/FilterPathGeneratorFilteringTests.java # libs/x-content/src/test/java/org/elasticsearch/xcontent/support/filtering/FilterPathTests.java
5 participants
add rolling upgrade tests for upgrade endpoint