Use short URLs for transform deprecation messages #79659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
hendrikmuhs
reviewed
Oct 25, 2021
.../plugin/core/src/main/java/org/elasticsearch/xpack/core/transform/TransformDeprecations.java
Outdated
Show resolved
Hide resolved
lcawl
force-pushed
the
transform-short-urls
branch
from
963a875 to
70cc316
Compare
lcawl
added a commit
to lcawl/elasticsearch
that referenced
this pull request
Oct 25, 2021
lcawl
added a commit
that referenced
this pull request
Oct 25, 2021
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces hard-coded URLs in transform deprecation messages with short URLs, which can be maintained outside the code.
In particular, it uses https://links.elastic.dev/alias/es-deprecation-8-transform-aggregation-options and https://links.elastic.dev/alias/es-deprecation-8-transform-query-options