Fix execution of exists query within nested queries on field with docvalues disabled #79462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_values disabled (elastic#78841) The FieldNamesFieldMapper adds non-indexed fields to a special metadata field so that exists queries can be run efficiently. This is built in a postParse method that is run once per document. However, this means that nested documents are not handled correctly - non-indexed field names are added to the parent document's metadata field rather than to the nested document's field. This commit fixes things to add non-indexed field names directly to the nested documents.
romseygeek
added a commit
to romseygeek/elasticsearch
that referenced
this pull request
Nov 3, 2021
…_values disabled (elastic#78841) (elastic#79462) The FieldNamesFieldMapper adds non-indexed fields to a special metadata field so that exists queries can be run efficiently. This is built in a postParse method that is run once per document. However, this means that nested documents are not handled correctly - non-indexed field names are added to the parent document's metadata field rather than to the nested document's field. This commit fixes things to add non-indexed field names directly to the nested documents. Co-authored-by: Yoann Rodière <[email protected]>
romseygeek
added a commit
that referenced
this pull request
Nov 3, 2021
…_values disabled (#78841) (#79462) (#80274) The FieldNamesFieldMapper adds non-indexed fields to a special metadata field so that exists queries can be run efficiently. This is built in a postParse method that is run once per document. However, this means that nested documents are not handled correctly - non-indexed field names are added to the parent document's metadata field rather than to the nested document's field. This commit fixes things to add non-indexed field names directly to the nested documents. Co-authored-by: Yoann Rodière <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FieldNamesFieldMapper adds non-indexed fields to a special metadata
field so that exists queries can be run efficiently. This is built in a postParse
method that is run once per document. However, this means that nested
documents are not handled correctly - non-indexed field names are added to
the parent document's metadata field rather than to the nested document's
field.
This commit fixes things to add non-indexed field names directly to the
nested documents.