Skip to content

Conversation

@Tim-Brooks
Copy link
Contributor

Currently the fleet search API does not work properly when no
checkpoints are provided. It throws an exception indicating that the
number of checkpoints do not match the number of shards. This PR fixes
the issue by allowing the search to progress if no checkpoints are
provided or if an empty array is provided.

Currently the fleet search API does not work properly when no
checkpoints are provided. It throws an exception indicating that the
number of checkpoints do not match the number of shards. This PR fixes
the issue by allowing the search to progress if no checkpoints are
provided or if an empty array is provided.
@Tim-Brooks Tim-Brooks added >bug :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. v8.0.0 v7.16.0 labels Oct 18, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Oct 18, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@Tim-Brooks Tim-Brooks added the Team:Clients Meta label for clients team label Oct 18, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@Tim-Brooks Tim-Brooks changed the title Fix fleet search API with no checkpints Fix fleet search API with no checkpoints Oct 18, 2021
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tim-Brooks Tim-Brooks merged commit dc071ae into elastic:master Oct 18, 2021
Tim-Brooks added a commit that referenced this pull request Oct 18, 2021
Currently the fleet search API does not work properly when no
checkpoints are provided. It throws an exception indicating that the
number of checkpoints do not match the number of shards. This PR fixes
the issue by allowing the search to progress if no checkpoints are
provided or if an empty array is provided.
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Oct 19, 2021
* upstream/master: (34 commits)
  Add extensionName() to security extension (elastic#79329)
  More robust and consistent allowAll indicesAccessControl (elastic#79415)
  Fix circuit breaker leak in MultiTerms aggregation (elastic#79362)
  guard geoline aggregation from parents aggegator that emit empty buckets (elastic#79129)
  Vector tiles: increase the size of the envelope used to clip geometries (elastic#79030)
  Revert "[ML] Add queue_capacity setting to start deployment API (elastic#79369)" (elastic#79374)
  Convert token service license object to LicensedFeature (elastic#79284)
  [TEST] Fix ShardPathTests for MDP (elastic#79393)
  Fix fleet search API with no checkpints (elastic#79400)
  Reduce BWC version for transient settings (elastic#79396)
  EQL: Rename a test class for eclipse (elastic#79254)
  Use search_coordination threadpool in field caps (elastic#79378)
  Use query param instead of a system property for opting in for new cluster health response code (elastic#79351)
  Add new kNN search endpoint (elastic#79013)
  Disable BWC tests
  Convert auditing license object to LicensedFeature (elastic#79280)
  Update BWC versions after backport of elastic#78551
  Enable InstantiatingObjectParser to pass context as a first argument (elastic#79206)
  Move xcontent filtering tests (elastic#79298)
  Update links to Fleet/Agent docs (elastic#79303)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. Team:Clients Meta label for clients team Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.16.0 v8.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants