Fix line separator in hot threads log assertion #79363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CoordinatorTests#testLogsMessagesIfPublicationDelayed` fails on Windows at an assertion about a log message which includes a `\n` character. This commit replaces that character with `System.lineSeparator()` to fix this assertion. Closes elastic#79359
DaveCTurner
added
>test
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
Author
|
@elasticmachine test this please |
Contributor
|
@elasticmachine run elasticsearch-ci/part-1-windows |
Contributor
|
@elasticmachine update branch |
DaveCTurner
added
auto-backport-and-merge
auto-merge-without-approval
Contributor
Author
|
Oh this is just stupid, multiline log messages are just invisible to |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Oct 18, 2021
* Fix line separator in hot threads log assertion `CoordinatorTests#testLogsMessagesIfPublicationDelayed` fails on Windows at an assertion about a log message which includes a `\n` character. This commit replaces that character with `System.lineSeparator()` to fix this assertion. Closes elastic#79359 * Skip assertion entirely Co-authored-by: Elastic Machine <[email protected]>
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 18, 2021
* Fix line separator in hot threads log assertion `CoordinatorTests#testLogsMessagesIfPublicationDelayed` fails on Windows at an assertion about a log message which includes a `\n` character. This commit replaces that character with `System.lineSeparator()` to fix this assertion. Closes #79359 * Skip assertion entirely Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoordinatorTests#testLogsMessagesIfPublicationDelayedfails on Windowsat an assertion about a log message which includes a
\ncharacter.This commit replaces that character with
System.lineSeparator()to fixthis assertion.
Closes #79359