Improve GeoIpDownloaderIT test suite and improve geoip failure tagging. #79131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case a database couldn't be loaded, the geoip processor factory checks whether any databases are available and then returns a processor implementation that tags documents with the fact that required database wasn't available. The GeoIpProcessor itself also loads the database, but in case a database can't be loaded then it always fails with resource missing exception. The GeoIpProcessor is modified in this change to also check whether any database is available and in that case tag documents instead of failing. GeoIpDownloaderIT improvements: * The `testUseGeoIpProcessorWithDownloadedDBs()` was adding databases to config dirs, but not cleaning it up. Which broke assumptions in others in this suite, because the test cluster is reused. * Use the geoip stats api after each test to wait for a clean state, which means wait for database downloader to be disabled and all database files to be removed on all ingest nodes. * Don't use `IngestDocument#getFieldValue(...)` in test code surrounded by `assertBusy(...)`. If a field isn't there an illegal state exception is thrown, which isn't caught by `assertBusy(...)`. Only assertion errors are handled. Closes elastic#79074
martijnvg
added
>non-issue
:Data Management/Ingest Node
elasticmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case a database couldn't be loaded, the geoip processor factory
checks whether any databases are available and then returns a processor
implementation that tags documents with the fact that required database
wasn't available. The GeoIpProcessor itself also loads the database, but
in case a database can't be loaded then it always fails with resource
missing exception. The GeoIpProcessor is modified in this change to
also check whether any database is available and in that case tag
documents instead of failing.
GeoIpDownloaderIT improvements:
testUseGeoIpProcessorWithDownloadedDBs()was adding databases to config dirs,but not cleaning it up. Which broke assumptions in others in this suite, because
the test cluster is reused.
wait for database downloader to be disabled and all database files to be removed
on all ingest nodes.
IngestDocument#getFieldValue(...)in test code surrounded byassertBusy(...).If a field isn't there an illegal state exception is thrown, which isn't caught by
assertBusy(...). Only assertion errors are handled.Closes #79074