[Transform] switch to a composable template for the audit index #79032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmuhs
force-pushed
the
transform-composable-template
branch
4 times, most recently
from
b1364ab to
322bf5a
Compare
added 7 commits
October 14, 2021 20:47
hendrikmuhs
force-pushed
the
transform-composable-template
branch
from
322bf5a to
74d42a3
Compare
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
hendrikmuhs
commented
Oct 14, 2021
|
|
||
| /** | ||
| * Waits for Machine Learning and Transform templates to be created by the {@link MetadataUpgrader} | ||
| * Waits for Machine Learning templates to be created by the {@link MetadataUpgrader} |
Author
There was a problem hiding this comment.
I intentionally removed the transform template here, I am confident this is not necessary and its unnatural, we don't do this in the product.
hendrikmuhs
commented
Oct 14, 2021
| } | ||
|
|
||
| @Override | ||
| public UnaryOperator<Map<String, IndexTemplateMetadata>> getIndexTemplateMetadataUpgrader() { |
Author
There was a problem hiding this comment.
AbstractAuditor takes care of everything since #63063
droberts195
approved these changes
Oct 14, 2021
droberts195
left a comment
droberts195
left a comment
There was a problem hiding this comment.
LGTM
I just saw a couple of nits in messages and comments
...ransform/src/main/java/org/elasticsearch/xpack/transform/notifications/TransformAuditor.java
Outdated
Show resolved
Hide resolved
...main/java/org/elasticsearch/xpack/transform/transforms/TransformPersistentTasksExecutor.java
Outdated
Show resolved
Hide resolved
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
hendrikmuhs
pushed a commit
to hendrikmuhs/elasticsearch
that referenced
this pull request
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch to a composable template for the audit index
relates #73232, #63063
(The code has not been touched for a while. The refactoring in #73232 and #63063 made it easy to switch and removed some dependencies)