Use correct terms in GET feature migration status API #79017
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamrandolph
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
williamrandolph
commented
Oct 12, 2021
| "migration_status" : "NO_MIGRATION_NEEDED" | ||
| } | ||
| -------------------------------------------------- | ||
| // TESTRESPONSE[s/"minimum_index_version" : "8.0.0"/"minimum_index_version" : $body.$_path/] |
Contributor
Author
There was a problem hiding this comment.
This is the one line in this PR that is not strictly changing the term "upgrade" to "migrate." It simply makes the docs tests ignore the actual version that is returned from the API so that we don't need to update this page for every release.
Collaborator
|
Pinging @elastic/clients-team (Team:Clients) |
sethmlarson
approved these changes
Oct 14, 2021
sabarasaba
approved these changes
Oct 15, 2021
Contributor
Author
|
Since there is a lot of turbulence on the 7.x and master branches, I'm closing this in favor of #79302, which is less likely to create merge conflicts for other work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #78802, we updated our docs to consistently use the term "migration" instead of "upgrade" for the operations that keep system indices up-to-date with the latest release of Elasticsearch.
In this PR, we change the terminology in both the code and the response of the GET feature migration status API.
I am holding off for the moment on changing the terms in the POST feature migration API to avoid any conflicts with #78951.