Speedup computing cluster health #78969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases the status is not GREEN. Instead of building a list of all shard routings and then counting the total and active number of shards, use the RoutingNodes (which should already be built) that can compute these numbers almost for free. Relates to elastic#77466
martijnvg
added
>enhancement
:Data Management/Stats
elasticmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
One thing to fix, otherwise this looks fine to me
| if (shard.relocating()) { | ||
| if (shard.active()) { | ||
| activeShardCount++; | ||
| } else if (shard.relocating()) { |
Contributor
There was a problem hiding this comment.
This is not correct. A relocating shard is also active. We must not use else if here but just if.
97 tasks
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Oct 12, 2021
In cases the status is not GREEN. Instead of building a list of all shard routings and then counting the total and active number of shards, use the RoutingNodes (which should already be built) that can compute these numbers almost for free. Relates to elastic#77466
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 12, 2021
In cases the status is not GREEN. Instead of building a list of all shard routings and then counting the total and active number of shards, use the RoutingNodes (which should already be built) that can compute these numbers almost for free. Relates to #77466
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases the status is not GREEN.
Instead of building a list of all shard routings and
then counting the total and active number of shards,
use the RoutingNodes (which should already be built)
that can compute these numbers almost for free.
Relates to #77466