Replace RoutingTable#shardsWithState(...) with RoutingNodes#unassigned(...) #78931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hState(...) Relates to elastic#77466
martijnvg
added
>enhancement
:Distributed Coordination/Allocation
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
reviewed
Oct 11, 2021
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Could we use RoutingNodes#unassigned() to iterate over the unassigned shards directly rather than copying them to an intermediate list first?
…hards_with_state_with_routing_nodes_shards_with_state
Member
Author
Yes, pushed via: 9f88b6e |
Member
Author
|
@elasticmachine run elasticsearch-ci/docs |
martijnvg
changed the title
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Oct 12, 2021
…d(...) (elastic#78931) Replaces only the production use cases of `RoutingTable#shardsWithState(...)` with `RoutingNodes#unassigned()`. Relates to elastic#77466
Collaborator
💚 Backport successful
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces only the production use cases of
RoutingTable#shardsWithState(...).Relates to #77466