-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Permit getting list of composable templates #78872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permit getting list of composable templates #78872
Conversation
5ee39ac to
4aed797
Compare
We document that `GET /_index_template/...` accepts a comma-separated list of template names but in fact today this API accepts only a single name or pattern. We expect folks sometimes to have enough templates to want to be able to request a list of them, so this commit generalises the API to accept a list as per the docs. It also adjusts `GET /_cat/templates` to use this new feature to filter the list of composable templates on the master rather than on the coordinating node.
4aed797 to
46f956a
Compare
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
@DaveCTurner we actually discussed this in the past and decided against adding functionality like this. The reason, if I recall, relates to the way we should handle partial failure of the request with and without wildcards. If the docs say we support that we should fix those so that they are correct. For example, here we explicitly removed docs for comma-separated list of names for deletion: #70649 |
|
WDYT about keeping this functionality in the transport action and just blocking it in the REST action? |
|
@DaveCTurner that works for me I think |
|
Actually on reflection the change to |
|
Closing this in favour of #78989 |
We document that
GET /_index_template/...accepts a comma-separatedlist of template names but in fact today this API accepts only a single
name or pattern. We expect folks sometimes to have enough templates to
want to be able to request a list of them, so this commit generalises
the API to accept a list as per the docs.
It also adjusts
GET /_cat/templatesto use this new feature to filterthe list of composable templates on the master rather than on the
coordinating node.