Skip to content

Fix AzureBlobContainerRetriesTests#testWriteLargeBlob #78777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2021
Merged

Fix AzureBlobContainerRetriesTests#testWriteLargeBlob #78777

merged 1 commit into from
Oct 6, 2021

Conversation

@fcofdez
Copy link
Contributor

@fcofdez fcofdez commented Oct 6, 2021

We are reading byte by byte there 🤦

@fcofdez fcofdez added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Oct 6, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 6, 2021

Pinging @elastic/es-distributed (Team:Distributed)

henningandersen
henningandersen approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fcofdez fcofdez merged commit 4cb6d25 into elastic:master Oct 6, 2021
@fcofdez
Copy link
Contributor Author

fcofdez commented Oct 6, 2021

Thanks Henning!

fcofdez added a commit to fcofdez/elasticsearch that referenced this pull request Oct 7, 2021
@fcofdez
Fix AzureBlobContainerRetriesTests#testWriteLargeBlob (elastic#78777)
972bd9a
fcofdez added a commit to fcofdez/elasticsearch that referenced this pull request Oct 7, 2021
@fcofdez
Fix AzureBlobContainerRetriesTests#testWriteLargeBlob (elastic#78777)
04cba7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henningandersen henningandersen henningandersen approved these changes

@original-brownbear original-brownbear Awaiting requested review from original-brownbear

Assignees

No one assigned

Labels

:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v8.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fcofdez @elasticmachine @henningandersen @jakelandis @elasticsearchmachine