Fix AzureBlobStore#convertStreamToByteBuffer chunking in Windows #78772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we were using Math.ceil in order to calculate the number of chunks in the request. Since we cast the values to a double... there be dragons. This could cause issues depending on the platform. This commit uses good old integers to compute the number of parts.
fcofdez
added
>bug
:Distributed Coordination/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
original-brownbear
approved these changes
Oct 6, 2021
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM, thanks Francisco!
| // by 64 elements), that's why we provide 64kb buffers. | ||
| return Flux.range(0, (int) Math.ceil((double) length / (double) chunkSize)) | ||
|
|
||
| // length it's at most 100MB so it's safe to cast back to an integer in this case |
Contributor
There was a problem hiding this comment.
length is I guess:)
fcofdez
added
the
auto-backport
Contributor
Author
|
Thanks Armin! |
fcofdez
added a commit
to fcofdez/elasticsearch
that referenced
this pull request
Oct 6, 2021
…stic#78772) Today we are using Math.ceil in order to calculate the number of chunks in the request. Since we cast the values to a double... there be dragons. This could cause issues depending on the platform. This commit uses good old integers to compute the number of parts.
This was referenced Oct 6, 2021
fcofdez
added a commit
to fcofdez/elasticsearch
that referenced
this pull request
Oct 6, 2021
…stic#78772) Today we are using Math.ceil in order to calculate the number of chunks in the request. Since we cast the values to a double... there be dragons. This could cause issues depending on the platform. This commit uses good old integers to compute the number of parts.
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we are using Math.ceil in order to calculate the number of
chunks in the request. Since we cast the values to a double...
there be dragons. This could cause issues depending on the platform.
This commit uses good old integers to compute the number of parts.