Node level can match action #78765
Merged
Node level can match action #78765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
reviewed
Oct 14, 2021
Member
dnhatn
left a comment
dnhatn
left a comment
There was a problem hiding this comment.
Thanks Yannick! I think the production code is ready :). We just need to add some tests then 🚢!
server/src/main/java/org/elasticsearch/transport/TransportActionProxy.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/search/SearchTransportService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/search/CanMatchPreFilterSearchPhase.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/search/CanMatchPreFilterSearchPhase.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/search/SearchTransportService.java
Show resolved
Hide resolved
jimczi
reviewed
Oct 15, 2021
Contributor
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
The change looks great!
I left one comment regarding the wait for checkpoint option.
I wonder, as a follow up, if we should use the new thread pool for the coordination of the other phases too ?
server/src/main/java/org/elasticsearch/action/search/AbstractSearchAsyncAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/search/CanMatchPreFilterSearchPhase.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/search/CanMatchRequest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/search/CanMatchResponse.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/threadpool/ThreadPool.java
Outdated
Show resolved
Hide resolved
jimczi
approved these changes
Oct 15, 2021
jimczi
added
:Search/Search
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
dnhatn
approved these changes
Oct 15, 2021
Member
|
@elasticmachine update branch |
ywelsch
added a commit
to ywelsch/elasticsearch
that referenced
this pull request
Oct 18, 2021
Changes can-match from a shard-level to a node-level action, which helps avoid an explosion of shard-level can-match subrequests in clusters with many shards, that can cause stability issues. Also introduces a new search_coordination thread pool to handle the sending and handling of node-level can-match requests.
ywelsch
added a commit
that referenced
this pull request
Oct 18, 2021
Changes can-match from a shard-level to a node-level action, which helps avoid an explosion of shard-level can-match subrequests in clusters with many shards, that can cause stability issues. Also introduces a new search_coordination thread pool to handle the sending and handling of node-level can-match requests.
ywelsch
added a commit
to ywelsch/elasticsearch
that referenced
this pull request
Oct 18, 2021
ywelsch
added a commit
that referenced
this pull request
Oct 18, 2021
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Oct 18, 2021
* upstream/master: Changing test keytab to use aes256-cts-hmac-sha1-96 instead of des3-cbc-sha1-kd (elastic#78703) Add support for configuring HNSW parameters (elastic#79193) Deprecate resolution loss on date field (elastic#78921) Add Optional to Configure bind user (elastic#78303) Adapt BWC after backporting elastic#78765 (elastic#79350) [DOCS] Add deprecation notice for reset password tool (elastic#78793) added test for flattened type in top_metrics.yml (elastic#78960) [DOCS] Fixes indentation issue in GET trained models API docs. (elastic#79347) Fix parsing of PBES2 encrypted PKCS#8 keys (elastic#78904) Mute testReindex (elastic#79343) Node level can match action (elastic#78765) Fix duplicate license header in source files (elastic#79236) AllowAll for indicesAccessControl (elastic#78498) Better logging and internal user handling for operator privileges (elastic#79331) # Conflicts: # server/src/main/java/org/elasticsearch/index/mapper/MappingParser.java
This was referenced Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes can-match from a shard-level to a node-level action, which helps avoid an explosion of shard-level can-match subrequests in clusters with many shards, that can cause stability issues. Also introduces a new
search_coordinationthread pool to handle the sending and handling of node-level can-match requests.