Skip to content

Conversation

@ppf2
Copy link
Contributor

@ppf2 ppf2 commented Oct 6, 2021

Adding this as a known issue (#78404) to the release notes for 7.14.x (fix will be in 7.15.1). Thx!

There is currently no plans to back port #78404 to 7.14.x.
Adding this as a known issue to the release notes for 7.14.x per discussion with @qhoxie .  Please also back port this doc change to 7.14.0 and 7.14.1. Thx!
@ppf2 ppf2 added the >docs General docs changes label Oct 6, 2021
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Oct 6, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added v7.14.3 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Oct 6, 2021
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ppf2 I left a couple of comments, otherwise looking good.

preview


[[known-issues-7.14.2]]
[discrete]
=== Known issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should include in the text that the issue exists since 7.14.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep thx!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find this in the text, only in the anchor above. I think we should simply call it out in the text below.

ppf2 added 5 commits October 6, 2021 09:45
Updated with 7.14.0-7.14.2 reference and explicitly call out its impact on Kibana CCS+aggregation requests.
Removed task cancellation as a workaround.
@ppf2
Copy link
Contributor Author

ppf2 commented Oct 6, 2021

@henningandersen Updated with your suggestions, thx! I will make the same changes (Kibana callout and removing task cancellation workaorund) to the 7.15.0 release notes PR.
@tbrooks8 Would you like to review as well?

@ppf2 ppf2 requested a review from henningandersen October 6, 2021 17:05
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ppf2 , a couple more comments.


Also see <<breaking-changes-7.14,Breaking changes in 7.14>>.

[[known-issues-7.14.0 to 7.14.2]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this does not work, see the preview.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I have always wondered how I can preview doc changes on our side. Thx for the link! I will remove the anchor and just have the info inline :)


[[known-issues-7.14.2]]
[discrete]
=== Known issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find this in the text, only in the anchor above. I think we should simply call it out in the text below.

ppf2 added 2 commits October 6, 2021 10:25
Removed anchor and placing affected versions inline.
fixing header
@ppf2 ppf2 requested review from jrodewig and removed request for Tim-Brooks October 6, 2021 18:26
@ppf2
Copy link
Contributor Author

ppf2 commented Oct 6, 2021

Fixed the headings and I think it looks good now.
Also removed Tim from the reviewer list (he says Henning's review will be sufficient).

@jrodewig Can you do a docs team review and help backport this to 7.14.1 and 7.14.0 release notes? (I think we will have to update the [[known-issues-7.14.2]] anchor when we do the backport so that the link will work correctly for previous releases). thx!

Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this @ppf2.

There are some wording improvements we can make here, but the current copy is clear enough; I don't want to hold this up any longer than needed.

I pushed some small commits to use attributes and reuse the copy in all 7.14 RNs. I'll get this merged and forward-ported to the 7.15 and 7.x branches.

@jrodewig jrodewig merged commit e868a02 into 7.14 Oct 6, 2021
@jrodewig jrodewig deleted the ppf2-aggregations-ccs-leak branch October 6, 2021 20:06
elasticsearchmachine pushed a commit that referenced this pull request Oct 6, 2021
…) (#78788)

Adds #78404 as a known issue to the 7.15.0 and 7.14.n release notes.

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: Pius <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Oct 6, 2021
…) (#78789)

Adds #78404 as a known issue to the 7.15.0 and 7.14.n release notes.

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: Pius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v7.14.3 v7.15.1 v7.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants