Expand segment sorter for all timeseries indices #78639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR elastic#75195 added segment sorter on @timestamp desc for datastream indices. This PR applies segment sorter to all indices that have @timestamp field. The presence of @timestamp field can serve as a strong indication that we are dealing with timeseries indices. The most common type of query for timeseries indices is to get the latest data, that is data sorted by @timestamp desc. This PR sorts segments by @timestamp desc which allows to speed up this kind of queries. Relates to elastic#75195
mayya-sharipova
added
the
:Search/Search
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
mayya-sharipova
added
>enhancement
v7.16.0
and removed
Team:Search
jimczi
reviewed
Oct 5, 2021
Contributor
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
Thanks @mayya-sharipova. I left one minor comment.
server/src/main/java/org/elasticsearch/cluster/metadata/DataStream.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/mapper/MappingLookup.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/shard/IndexShard.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@jimczi Thanks for the review, can you please continue to review when you have time |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/part-2 |
mayya-sharipova
added a commit
to mayya-sharipova/elasticsearch
that referenced
this pull request
Oct 5, 2021
PR elastic#75195 added segment sorter on @timestamp desc for datastream indices. This PR applies segment sorter to all indices that have @timestamp field. The presence of @timestamp field can serve as a strong indication that we are dealing with timeseries indices. The most common type of query for timeseries indices is to get the latest data, that is data sorted by @timestamp desc. This PR sorts segments by @timestamp desc which allows to speed up this kind of queries. Backport for elastic#78639 Relates to elastic#75195
mayya-sharipova
added a commit
that referenced
this pull request
Oct 5, 2021
PR #75195 added segment sorter on @timestamp desc for datastream indices. This PR applies segment sorter to all indices that have @timestamp field. The presence of @timestamp field can serve as a strong indication that we are dealing with timeseries indices. The most common type of query for timeseries indices is to get the latest data, that is data sorted by @timestamp desc. This PR sorts segments by @timestamp desc which allows to speed up this kind of queries. Backport for #78639 Relates to #75195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #75195 added segment sorter on @timestamp desc for datastream indices.
This PR applies segment sorter to all indices that have @timestamp
field.
The presence of @timestamp field can serve as a strong
indication that we are dealing with timeseries indices. The most
common type of query for timeseries indices is to get the latest data,
that is data sorted by @timestamp desc. This PR sorts segments
by @timestamp desc which allows to speed up this kind of queries.
Relates to #75195