Remove example-plugins included build #78408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove this included build for now since it causes a number of problems. Firstly, Eclipse buildship cannot handle this scenario and locks up during project import. Secondly, we've seen similar issues with hung builds in CI as well, which I think is related. The core issue being Gradle doesn't handle cyclical composite builds well, or at all really. This is a specifically supported use case so for now we'll just separate the two and go with the original plan of having parallel CI jobs to test the example plugins.
mark-vieira
added
>non-issue
:Delivery/Build
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
pugnascotia
approved these changes
Sep 28, 2021
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Sep 28, 2021
# Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/test/DistroTestPlugin.java
mark-vieira
added a commit
that referenced
this pull request
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove this included build for now since it causes a number of problems.
Firstly, Eclipse buildship cannot handle this scenario and locks up
during project import. Secondly, we've seen similar issues with hung
builds in CI as well, which I think is related. The core issue being
Gradle doesn't handle cyclical composite builds well, or at all really.
This is a specifically supported use case so for now we'll just
separate the two and go with the original plan of having parallel CI
jobs to test the example plugins.