Skip to content

Conversation

@jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Sep 28, 2021

@jrodewig jrodewig changed the title [DOCS] Queries on _type field match no docs [DOCS] Search on _type field matches no docs Sep 28, 2021
Adds an 8.0 breaking change for PR #68564
@jrodewig jrodewig added :Search/Search Search-related issues that do not fall into other categories >docs General docs changes labels Sep 28, 2021
@jrodewig jrodewig marked this pull request as ready for review September 28, 2021 16:52
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Search Meta label for search team labels Sep 28, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)


//tag::notable-breaking-changes[]
[[_type-search-matches-no-docs]]
.A search on the `_type` field now matches no documents.
Copy link
Contributor

@jtibshirani jtibshirani Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a clearer way to phrase this would be "searches on _type are no longer supported". We actually completely removed support for searching on _type -- it's not recognized as a valid field. It just so happens that searches on non-existent fields will return no results. This note might suggest that _type is still a valid metadata field, whereas it doesn't exist anymore!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtibshirani. I added some additional context with 581393e.

@jrodewig jrodewig changed the title [DOCS] Search on _type field matches no docs [DOCS] Searches on the _type field are no longer supported. Sep 28, 2021
@jrodewig jrodewig changed the title [DOCS] Searches on the _type field are no longer supported. [DOCS] Searches on the _type field are no longer supported Sep 28, 2021
Copy link
Contributor

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jrodewig jrodewig merged commit 58595e7 into elastic:master Sep 28, 2021
@jrodewig jrodewig deleted the docs__remove-type-searches branch September 28, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes :Search/Search Search-related issues that do not fall into other categories Team:Docs Meta label for docs team Team:Search Meta label for search team v8.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants