Skip to content

Conversation

@Luegg
Copy link
Contributor

@Luegg Luegg commented Sep 28, 2021

Backports the following commits to 7.x:

* SQL: fix NULLS FIRST/LAST for aggregations

* adding bwc tests

* address review comments
# Conflicts:
#	x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/querydsl/agg/GroupByDateHistogram.java
#	x-pack/plugin/sql/src/test/java/org/elasticsearch/xpack/sql/planner/QueryFolderTests.java
@Luegg Luegg added backport auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Sep 28, 2021
@elasticsearchmachine elasticsearchmachine merged commit ff34b2e into elastic:7.x Sep 28, 2021
Luegg pushed a commit that referenced this pull request Sep 28, 2021
Fixes and enables the full bwc tests introduced in #77750 after backporting to 7.16. The changes to the tests have already been applied to 7.x in the backport PR #78363.
@Luegg Luegg deleted the backport/7.x/pr-77750 branch September 29, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v7.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants