Automatically install monitoring templates at plugin initialization #78350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows it to better replace the MonitoringTemplateUtils class.
…sing. Update template name uses away from MonitoringTemplateUtils.
Only install templates if there is a template source given (for now)
Only target .monitoring indices when asserting index count, since readying the local exporter will create a watcher index that trips up the test.
No longer assumes that templates will be installed by the exporter.
No longer assumes that templates will be installed by the exporter. Added some additional trace logging lines to aid in debugging these tests.
elasticmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Member
Author
|
@elasticmachine update branch |
Member
Author
|
Changing to the deprecation label since we have re-added the removed setting in 8.0 to allow for a longer deprecation cycle. The setting will not break 8.0 nodes on start up, but it will not have any functionality tied to it. |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
MonitoringIndexTemplateRegistryto the monitoring plugin which automatically installs all monitoring templates locally when the plugin is initialized. Exporters have been updated to no longer attempt installation of the monitoring templates, and instead will wait for the templates to become available before setting themselves as started. Some older functionality related to templates has been removed as well, such as the expectation that version 6 monitoring templates are installed, as well as the setting that controls their installation (xpack.monitoring.exporters.<EXPORTER>.index.template.create_legacy_templates).