Deprecate returning 408 for a server timeout on _cluster/health
#78180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@elasticmachine update branch |
arteam
force-pushed
the
return-200-for-cluster-health-timeout
branch
2 times, most recently
from
d40180f to
978a748
Compare
arteam
changed the title
_cluster/health_cluster/health
Make sure we don't get a 408 HTTP response code
We should return 200 OK
The cluster health endpoint now returns 200 OK instead of 408
arteam
force-pushed
the
return-200-for-cluster-health-timeout
branch
from
978a748 to
97499e7
Compare
arteam
added
the
:Distributed Indexing/CRUD
elasticmachine
added
the
Team:Distributed (Obsolete)
arteam
force-pushed
the
return-200-for-cluster-health-timeout
branch
from
61f862f to
231c884
Compare
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/bwc |
Contributor
Author
|
@elasticmachine update branch |
Collaborator
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Oct 11, 2021
…h` (elastic#78180) Backports elastic#78180 to 7.x. Add a deprecation warning and a system property es.cluster_health.request_timeout_200 to opt in for returning 200 which will be the default in 8.0.0 Fixes elastic#70849
arteam
added a commit
that referenced
this pull request
Oct 11, 2021
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Oct 19, 2021
Documents the deprecation introduced in elastic#78180 and adjusted in elastic#79351.
DaveCTurner
added a commit
that referenced
this pull request
Oct 19, 2021
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Nov 6, 2021
Returning 408 for a cluster health timeout was deprecated in elastic#78180 and backported to 7.x in elastic#78940 Now we can do a breaking change in 8.0 respecting the user choice to run ES in 7.x compatible mode via the REST Compatibility layer. Fixes elastic#70849
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Nov 18, 2021
…lth` (elastic#78180)" This reverts commit f266eb3
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Nov 18, 2021
…lth` (elastic#78180)" This reverts commit f266eb3
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Nov 18, 2021
…er/health` (elastic#78180) (elastic#78940)" This reverts commit 03bd55d
arteam
added a commit
that referenced
this pull request
Nov 18, 2021
…ter/health` (#78180)" (#80831) * Revert "Allow deprecation warning for the return_200_for_cluster_health_timeout parameter (#80178) (#80445)" This reverts commit 5a53007. * Revert "[7.x] Use query param instead of a system property for opting in for new cluster health response code (#79397) (#79435)" This reverts commit d8c1428 * Revert "[7.x] Deprecate returning 408 for a server timeout on `_cluster/health` (#78180) (#78940)" This reverts commit 03bd55d
arteam
added a commit
that referenced
this pull request
Nov 18, 2021
#78968)" (#80826) * [8.0] Revert "Return 200 OK response code for a cluster health timeout (#78968)" This reverts commit a2c3dae * Revert "Allow deprecation warning for the return_200_for_cluster_health_timeout parameter (#80178) (#80444)" This reverts commit 4102cf7. * Revert "Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551)" This reverts commit b9fbe66. * Revert "Adjust the BWC version for the return200ForClusterHealthTimeout field (#79436)" This reverts commit f60bda5. * Revert "Use query param instead of a system property for opting in for new cluster health response code (#79351)" This reverts commit 8901a99 * Revert "Deprecate returning 408 for a server timeout on `_cluster/health` (#78180)" This reverts commit f266eb3 * Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551) This reverts commit fa4d562. * Revert "[8.0] Disable BWC for #80821 (#80840)"
arteam
added a commit
that referenced
this pull request
Nov 18, 2021
)" (#80821) * Revert "Return 200 OK response code for a cluster health timeout (#78968)" This reverts commit a2c3dae * Revert "Allow deprecation warning for the return_200_for_cluster_health_timeout parameter (#80178)" This reverts commit 1c711e3. * Revert "Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551)" This reverts commit b9fbe66. * Revert "Adjust the BWC version for the return200ForClusterHealthTimeout field (#79436)" This reverts commit f60bda5. * Revert "Use query param instead of a system property for opting in for new cluster health response code (#79351)" This reverts commit 8901a99 * Revert "Deprecate returning 408 for a server timeout on `_cluster/health` (#78180)" This reverts commit f266eb3 * Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551) This reverts commit fa4d562 * Revert "Disable BWC for #80821 (#80839)" This reverts commit cb0e73e. Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a deprecation warning and a system property
es.cluster_health.request_timeout_200to opt in for returning 200 which will be the default in 8.0.0Fixes #70849