Fix watcher check that determines when to serialize indices options. #78070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check was an identity check between the default constant and the set indices options. This check is incorrect because in many cases when `IndicesOptions` is parsed or randomly generated in tests, then this check incorrectly returns false when in fact an `IndicesOptions` instance is equal to the default constant, but it is just a different instance/object. Closes elastic#78035
elasticmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Sep 22, 2021
Backporting elastic#78070 to 7.x branch. The check was an identity check between the default constant and the set indices options. This check is incorrect because in many cases when `IndicesOptions` is parsed or randomly generated in tests, then this check incorrectly returns false when in fact an `IndicesOptions` instance is equal to the default constant, but it is just a different instance/object. Closes elastic#78035
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 22, 2021
…78165) Backporting #78070 to 7.x branch. The check was an identity check between the default constant and the set indices options. This check is incorrect because in many cases when `IndicesOptions` is parsed or randomly generated in tests, then this check incorrectly returns false when in fact an `IndicesOptions` instance is equal to the default constant, but it is just a different instance/object. Closes #78035
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check was an identity check between the default constant and
the set indices options. This check is incorrect because in many
cases when
IndicesOptionsis parsed or randomly generated in tests,then this check incorrectly returns false when in fact an
IndicesOptionsinstance is equal to the default constant, but it is just a different
instance/object.
Closes #78035