Fix split package in analysis-smartcn plugin #78045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The analysis-smartcn plugin reuses server the server package name for analysis. This commit moves the plugin implementation to use a single package name, o.e.p.analysis.smartcn
rjernst
added
>non-issue
:Search Relevance/Analysis
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
romseygeek
approved these changes
Sep 21, 2021
Contributor
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
LGTM.
Is the plan to eventually move all of our plugins to org.elasticsearch.plugin.XXX packages?
Member
Author
|
It is A plan, and it it is what I’ve been using to fix these specific split package problems, but there isn’t any broad agreement on plugins package naming. |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 21, 2021
The analysis-smartcn plugin reuses server the server package name for analysis. This commit moves the plugin implementation to use a single package name, o.e.p.analysis.smartcn
Contributor
|
I'm also trying to figure out the naming scheme, as I review related PRs. When do we include |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 21, 2021
The analysis-smartcn plugin reuses server the server package name for analysis. This commit moves the plugin implementation to use a single package name, o.e.p.analysis.smartcn Co-authored-by: Elastic Machine <[email protected]>
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The analysis-smartcn plugin reuses server the server package name for
analysis. This commit moves the plugin implementation to use a single
package name, o.e.p.analysis.smartcn