Skip to content

Conversation

@dnhatn
Copy link
Member

@dnhatn dnhatn commented Sep 15, 2021

To include LUCENE-10106 so we don't need to revert the sort optimization introduced in #64292.

@dnhatn dnhatn added >non-issue :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.16.0 labels Sep 15, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Sep 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@dnhatn dnhatn requested a review from romseygeek September 15, 2021 16:32
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dnhatn

Copy link
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @dnhatn

@mayya-sharipova
Copy link
Contributor

It looks like this test is failing: "org.elasticsearch.xpack.core.security.support.AutomatonsTests.testSettingMaxDeterminizedStates"
Looks to be related to this lucene commit

@dnhatn
Copy link
Member Author

dnhatn commented Sep 16, 2021

@mayya-sharipova We are now failing with the validation introduced in apache/lucene#283. The problem is that we use SortField.LONG for an integer field. Would you mind taking a look?

@mayya-sharipova
Copy link
Contributor

Sorry for the trouble @dnhatn. We need to backport this @jimczi PR to lucene-solr 8.x. I will do that.

@dnhatn dnhatn changed the title Upgrade to Lucene-8.10.0-snapshot-75a5061d371 Upgrade to Lucene-8.10.0-snapshot-bf2fcb53079 Sep 16, 2021
@dnhatn dnhatn merged commit 05c25e4 into elastic:master Sep 16, 2021
@dnhatn dnhatn deleted the upgrade-lucene-8_10 branch September 16, 2021 16:23
dnhatn added a commit that referenced this pull request Sep 16, 2021
This commit adjust Lucene version in 7x after it was upgraded to Lucene 8.10.

Relates #77801
Relates #77898
wjp719 added a commit to wjp719/elasticsearch that referenced this pull request Sep 18, 2021
* master: (185 commits)
  Implement get and containsKey in terms of the wrapped innerMap (elastic#77965)
  Adjust Lucene version and enable BWC tests (elastic#77933)
  Disable BWC to upgrade to Lucene-8.10-snapshot
  Reenable MlDistributedFailureIT
  [DOCS] Fix typo for `script.painless.regex.enabled` setting value (elastic#77853)
  Upgrade to Lucene-8.10.0-snapshot-bf2fcb53079 (elastic#77801)
  [DOCS] Fix ESS install lead-in (elastic#77887)
  Resolve thirdparty gradle plugin artifacts from mavencentral (elastic#77865)
  Reduce the number of times that `LifecycleExecutionState` is parsed when running a policy. (elastic#77863)
  Utility methods to add and remove backing indices from data streams (elastic#77778)
  Use Objects.equals() instead of == to compare strings (elastic#77840)
  [ML] prefer least allocated model when a new node is added to the cluster (elastic#77756)
  Deprecate ignore_throttled parameter (elastic#77479)
  Improve LifecycleExecutionState parsing. (elastic#77855)
  [DOCS] Removes deprecated word from HLRC title. (elastic#77851)
  Remove legacy geo code from AggregationResultUtils (elastic#77702)
  Adjust SearchableSnapshotsBlobStoreCacheIntegTests.testBlobStoreCache (elastic#77758)
  Laxify SecureSM to allow creation of the JDK's innocuous threads (elastic#77789)
  [Test] Reduce concurrency when testing creation of security index (elastic#75293)
  Refactor metric PipelineAggregation integration test (elastic#77548)
  ...

# Conflicts:
#	server/src/main/java/org/elasticsearch/cluster/metadata/DataStream.java
pheyos added a commit to elastic/kibana that referenced this pull request Sep 27, 2021
With the Elasticsearch fix elastic/elasticsearch#77801 merged, we can now re-enable the test suites that have been skipped due to the corresponding sort optimization issue.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 27, 2021
With the Elasticsearch fix elastic/elasticsearch#77801 merged, we can now re-enable the test suites that have been skipped due to the corresponding sort optimization issue.
kibanamachine added a commit to elastic/kibana that referenced this pull request Sep 27, 2021
With the Elasticsearch fix elastic/elasticsearch#77801 merged, we can now re-enable the test suites that have been skipped due to the corresponding sort optimization issue.

Co-authored-by: Robert Oskamp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v7.16.0 v8.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants