Make Failing Transport Handlers on Node Shutdown More Reliable #77783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't fork when shutting down already as the generic pool may not execute all tasks queued up on it silently. Also, when handling exceptions in the peer recovery target service, don't try to re-schedule recoveries when the node is shutting down already and fail right away no matter the exception. closes elastic#77017
original-brownbear
added
>test-failure
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
Author
|
Thanks Tanguy! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Sep 15, 2021
…ic#77783) Don't fork when shutting down already as the generic pool may not execute all tasks queued up on it silently. Also, when handling exceptions in the peer recovery target service, don't try to re-schedule recoveries when the node is shutting down already and fail right away no matter the exception. closes elastic#77017
original-brownbear
added a commit
that referenced
this pull request
Sep 15, 2021
… (#77794) Don't fork when shutting down already as the generic pool may not execute all tasks queued up on it silently. Also, when handling exceptions in the peer recovery target service, don't try to re-schedule recoveries when the node is shutting down already and fail right away no matter the exception. closes #77017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't fork when shutting down already as the generic pool may not execute all
tasks queued up on it silently.
Also, when handling exceptions in the peer recovery target service, don't try to
re-schedule recoveries when the node is shutting down already and fail right away
no matter the exception.
closes #77017