Notify stubbable transport behaviors on clear #77774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `MockTransportService#addUnresponsiveRule` adds a rule that drops requests to a node then we must notify the rule on removal so that the requests don't leak. Today we notify rules when removing them from a specific address but not if clearing all rules. This commit addresses that. Closes elastic#77751
DaveCTurner
added
>test
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
Author
|
@elasticmachine please run elasticsearch-ci/packaging-tests-unix-sample |
Contributor
Author
|
Failure looks to be #77539. |
Contributor
Author
|
@elasticmachine please run elasticsearch-ci/part-1 |
Contributor
|
I'll look at this today. |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Oct 25, 2021
If `MockTransportService#addUnresponsiveRule` adds a rule that drops requests to a node then we must notify the rule on removal so that the requests don't leak. Today we notify rules when removing them from a specific address but not if clearing all rules. This commit addresses that. Closes elastic#77751
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Oct 25, 2021
If `MockTransportService#addUnresponsiveRule` adds a rule that drops requests to a node then we must notify the rule on removal so that the requests don't leak. Today we notify rules when removing them from a specific address but not if clearing all rules. This commit addresses that. Closes elastic#77751
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 25, 2021
If `MockTransportService#addUnresponsiveRule` adds a rule that drops requests to a node then we must notify the rule on removal so that the requests don't leak. Today we notify rules when removing them from a specific address but not if clearing all rules. This commit addresses that. Closes #77751
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 25, 2021
If `MockTransportService#addUnresponsiveRule` adds a rule that drops requests to a node then we must notify the rule on removal so that the requests don't leak. Today we notify rules when removing them from a specific address but not if clearing all rules. This commit addresses that. Closes #77751
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Oct 28, 2021
If `MockTransportService#addUnresponsiveRule` adds a rule that drops requests to a node then we must notify the rule on removal so that the requests don't leak. Today we notify rules when removing them from a specific address but not if clearing all rules. This commit addresses that. Closes elastic#77751
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
MockTransportService#addUnresponsiveRuleadds a rule that dropsrequests to a node then we must notify the rule on removal so that the
requests don't leak. Today we notify rules when removing them from a
specific address but not if clearing all rules. This commit addresses
that.
Closes #77751